Alon Bar-Lev has posted comments on this change. Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31423/1/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 177: with_dep = set(modules) Line 178: for c in _configurers: Line 179: if c.getName() in modules: Line 180: with_dep.update(c.requires()) Line 181: return list(with_dep) shouldn't this be logically reversed? dirty = True while dirty: dirty = False for module in modules: get module by name if dependencies not in modules add dependency into modules dirty = True just based of names... Line 182: Line 183: Line 184: def _sort_modules(modules): Line 185: sortedModules = [] Line 185: sortedModules = [] Line 186: while modules: Line 187: foundNext = False Line 188: Line 189: for c in _configurers: I do not understand the usage of _configurers, it is just the global list that is to be assigned by default, or to be able to resolve modules. the loops should always start at modules. Line 190: if c.getName() in modules: Line 191: if not c.requires() or c.requires().issubset(sortedModules): Line 192: foundNext = True Line 193: modules.remove(c.getName()) -- To view, visit http://gerrit.ovirt.org/31423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf63ce9aa3ca8edb82091d09b976e8e23896524e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
