mooli tayer has posted comments on this change. Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31423/2/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 251: args.modules = _getConfigurers().keys() Line 252: else: Line 253: _validateModulesNames(args.modules, parser.format_usage()) Line 254: Line 255: args.modules = _sort_modules(_add_dependencies(args.modules)) > I expect a simple error. usage can be printed when people do --help. no nee OK. Done Line 256: Line 257: args.modules = [_getConfigurers()[cName] for cName in args.modules] Line 258: -- To view, visit http://gerrit.ovirt.org/31423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf63ce9aa3ca8edb82091d09b976e8e23896524e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
