Nir Soffer has posted comments on this change. Change subject: vdsm-tool: changing root checking in configurator. ......................................................................
Patch Set 3: (1 comment) Mooli, did you search for imports of NoRootError, and eliminated all places using @requiresRoot? http://gerrit.ovirt.org/#/c/31293/3/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 38: SANLOCK_ENABLED, \ Line 39: SANLOCK_USER, \ Line 40: SYSCONF_PATH, \ Line 41: VDSM_GROUP Line 42: from . import NotRootError, requiresRoot, UsageError I think that you don't need NoRootError any more, unless you have duplicate code raising it :-) Line 43: from . import service, expose, validate_ovirt_certs Line 44: from .. import utils Line 45: from vdsm.config import config Line 46: -- To view, visit http://gerrit.ovirt.org/31293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
