Nir Soffer has posted comments on this change. Change subject: vdsm-tool: changing root checking in configurator. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/31293/4/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 672: ) Line 673: Line 674: Line 675: @expose("configure") Line 676: @requiresRoot > and what if someone imports configurator and run LibvirtModuleConfigure.con This module is not a library, but part of vdsm-tool. If you want to use in incorrectly, its your problem. Line 677: def configure(*args): Line 678: """ Line 679: configure [-h|...] Line 680: Configure external services for vdsm -- To view, visit http://gerrit.ovirt.org/31293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52967e30f677e4537b83c2db442963e3eadecb55 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
