Federico Simoncelli has posted comments on this change. Change subject: sparsify: integrating virt-sparsify into vdsm ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/28328/12/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 1629: pool = self.getPool(spUUID) Line 1630: Line 1631: if tmpSdUUID == dstSdUUID: Line 1632: sdUUIDs = [tmpSdUUID] Line 1633: else: You can drop this part above: sdUUIDs = sorted(set((tmpSdUUID, dstSdUUID))) does it all. Line 1634: sdUUIDs = sorted(set((tmpSdUUID, dstSdUUID))) Line 1635: Line 1636: for dom in sdUUIDs: Line 1637: vars.task.getSharedLock(STORAGE, dom) -- To view, visit http://gerrit.ovirt.org/28328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7bd2b4b6d45781fa27a128dd68d14b7561d0901 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Utkarsh Singh <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Utkarsh Singh <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
