Dan Kenigsberg has posted comments on this change. Change subject: Create GuestAgent instance in __init__ and connect later ......................................................................
Patch Set 11: Code-Review-1 (1 comment) I really want this cleanup patch in - but please simplify it a bit more. http://gerrit.ovirt.org/#/c/26142/11/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 138: def connect(self): Line 139: try: Line 140: self._prepare_socket() Line 141: except: Line 142: self.log.error("Failed to prepare vmchannel", exc_info=True) There is no need to log the backtrace twice. Since we re-raise, the caller of connect() would log it. As far as I see, there is no need for exception handling in this level. Line 143: raise Line 144: else: Line 145: self._channelListener.register( Line 146: self._create, -- To view, visit http://gerrit.ovirt.org/26142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
