Dan Kenigsberg has submitted this change and it was merged. Change subject: Create GuestAgent instance in __init__ and connect later ......................................................................
Create GuestAgent instance in __init__ and connect later This is not only a cosmetic improvement. There are cases where we are trying to call methods of the GuestAgent before the instance was created. To avoid these race conditions we're creating the instance of the guest agent already in the __init__ phase. Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13 Signed-off-by: Vinzenz Feenstra <[email protected]> Reviewed-on: http://gerrit.ovirt.org/26142 Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/guestagentTests.py M tests/vmTests.py M vdsm/virt/guestagent.py M vdsm/virt/vm.py M vdsm/virt/vmpowerdown.py 5 files changed, 37 insertions(+), 37 deletions(-) Approvals: Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/26142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I82f7397b01bff48a3c635eee9912cc67cf722b13 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
