mooli tayer has posted comments on this change. Change subject: vdsm-tool: suppoort dependencies between ModuleConfigure ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/31423/3/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 186: sys.stdout.write( Line 187: "error: argument --module: " Line 188: "invalid choice: %s (choose from %s)" % (modulesNames, next_) Line 189: ) Line 190: sys.exit(2) > why don't you raise an exception? I wanted to return identically as if parser.parse_args has failed and that what it does. I've removed below the usage of it's 'choices=' since it interferes with my testing mocks. Line 191: Line 192: return retNames Line 193: Line 194: -- To view, visit http://gerrit.ovirt.org/31423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf63ce9aa3ca8edb82091d09b976e8e23896524e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
