Liron Aravot has posted comments on this change. Change subject: Handle and store serial to guest device names mapping ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/31497/2/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 119: self._socketName = socketName Line 120: self._sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) Line 121: self._stopped = True Line 122: self.guestStatus = None Line 123: self.guestDiskMapping = [] why it's not in self.guestInfo? Line 124: self.guestInfo = { Line 125: 'username': user, Line 126: 'memUsage': 0, Line 127: 'guestCPUCount': -1, Line 300: disk['total'] = str(disk['total']) Line 301: disk['used'] = str(disk['used']) Line 302: disks.append(disk) Line 303: self.guestDiskMapping = [] Line 304: self.guestInfo['disksUsage'] = disks please replace 303-304 for better readability Line 305: if 'mapping' in args: Line 306: for disk in args['mapping']: Line 307: self.guestDiskMapping.append({'serial': disk['serial'], Line 308: 'name': disk['name']}) -- To view, visit http://gerrit.ovirt.org/31497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69db18414b17b23eb7bcbfbd8b2584f622e53276 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
