Vinzenz Feenstra has posted comments on this change. Change subject: Handle and store serial to guest device names mapping ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/31497/2/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 304: self.guestInfo['disksUsage'] = disks Line 305: if 'mapping' in args: Line 306: for disk in args['mapping']: Line 307: self.guestDiskMapping.append({'serial': disk['serial'], Line 308: 'name': disk['name']}) > Regarding the mapping, this is now question for engine guys, how do they wa Clearing the list explicitly was intentional. As an older version of the guest agent might not contain the 'mapping' variable in the message and then it's not sure if the disk is still there. If someone then would hot unplug a disk, it would be still reported even though it is no longer there. (That is if I would not be clearing the value) Line 309: elif message == 'number-of-cpus': Line 310: self.guestInfo['guestCPUCount'] = int(args['count']) Line 311: else: Line 312: self.log.error('Unknown message type %s', message) -- To view, visit http://gerrit.ovirt.org/31497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69db18414b17b23eb7bcbfbd8b2584f622e53276 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
