Francesco Romani has posted comments on this change.
Change subject: vm: ensure valid Vm._dom before domDependentInit
......................................................................
Patch Set 3: Verified+1
Changes:
- enhanced the exception to preserve the exitReason
- make sure we report as soon as possible the VM as Down and abort creation if
_dom is missing.
Verified with 28511:
verification:
- booted a VM, restared VDSM while VM was UP: recovery OK, vm reported as UP
- booted a VM, while VM was UP stopped VDSM, virsh destroy'd VM, restared VDSM.
as expected, VDSM tried recovery which failed with
Thread-13::DEBUG::2014-08-19
09:17:36,471::libvirtconnection::143::root::(wrapper) Unknown libvirterror:
ecode: 42 edom: 10 level: 2 message: Domain not found: no domain with matching
uuid 'b63bfabf-6be6-4273-b133-3f8a068f52ac'
Thread-13::DEBUG::2014-08-19
09:17:36,471::vm::1908::vm.Vm::(_startUnderlyingVm)
vmId=`b63bfabf-6be6-4273-b133-3f8a068f52ac`::_ongoingCreations released
Thread-13::DEBUG::2014-08-19 09:17:36,472::vm::2426::vm.Vm::(setDownStatus)
vmId=`b63bfabf-6be6-4273-b133-3f8a068f52ac`::Changed state to Down: Failed to
find the libvirt domain (code=9)
- migration of a single VM *to* a patched VDSM: completed succesfully (basic
case)
- migration of a single VM *to* a patched VDSM: restarted VDSM on destination
while migration in progress:
VDSM waited for the migration to complete as expected:
Thread-14::DEBUG::2014-08-19 09:37:55,365::vm::686::vm.Vm::(__init__)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Ignoring param (target, 4194304)
in BalloonDevice
Thread-14::DEBUG::2014-08-19
09:37:55,369::vm::1908::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::_ongoingCreations released
Thread-14::INFO::2014-08-19 09:37:55,376::vm::2774::root::(_isDomainRunning)
>>> 56d1c657-dd76-4609-a207-c050699be5be: running=False
Thread-14::DEBUG::2014-08-19
09:37:55,376::vm::3756::vm.Vm::(_waitForUnderlyingMigration)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Waiting 21600 seconds for end of
migration
- migration of a single VM *to* a patched VDSM: begun migration, stopped VDSM
on the destination host,
waited for migration to complete (using engine and vdsClient), after that
started VDSM on destination host.
Detection worked as expected:
Thread-13::DEBUG::2014-08-19 09:45:50,482::vm::686::vm.Vm::(__init__)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Ignoring param (target, 4194304)
in BalloonDevice
Thread-13::DEBUG::2014-08-19
09:45:50,508::vm::1908::vm.Vm::(_startUnderlyingVm)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::_ongoingCreations released
Thread-13::INFO::2014-08-19 09:45:50,510::vm::2774::root::(_isDomainRunning)
>>> 56d1c657-dd76-4609-a207-c050699be5be: running=True
Thread-13::INFO::2014-08-19
09:45:50,510::vm::3728::vm.Vm::(_completeIncomingMigration)
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::migration completed while
recovering!
further proof (toji = destination host)
$ vdsctl toji getAllVmStats
56d1c657-dd76-4609-a207-c050699be5be
Status = Up
[...]
--
To view, visit http://gerrit.ovirt.org/30146
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2840b066260790d4f3079a9cd34f87a70e96891
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
