Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: ensure valid Vm._dom before domDependentInit ......................................................................
vm: ensure valid Vm._dom before domDependentInit If we reach the _domDependentInit stage of a VM creation, for every possible flow, including recovery, we must guarantee that the _dom attribute is not None, thus VDSM and libvirt are connected. Quite a lot of errors could be ignored on recovery, but this cannot, ever. This patch moves the '_dom is not None' check inside _domDependentInit, and makes it mandatory for each flow. Change-Id: Ie2840b066260790d4f3079a9cd34f87a70e96891 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/30146 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 15 insertions(+), 8 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/30146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2840b066260790d4f3079a9cd34f87a70e96891 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
