Nir Soffer has uploaded a new change for review. Change subject: tool: Remove pointless __init__ methods ......................................................................
tool: Remove pointless __init__ methods Some configurators had pointless __init__ methods. There is not need to implement these if they are empty. Keeping them only cause developers to copy and paste this useless code when they create new configurators. Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96 Signed-off-by: Nir Soffer <[email protected]> --- M lib/vdsm/tool/configurators/__init__.py M lib/vdsm/tool/configurators/sanlock.py 2 files changed, 0 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/31740/1 diff --git a/lib/vdsm/tool/configurators/__init__.py b/lib/vdsm/tool/configurators/__init__.py index 219d119..49071ff 100644 --- a/lib/vdsm/tool/configurators/__init__.py +++ b/lib/vdsm/tool/configurators/__init__.py @@ -44,9 +44,6 @@ class ModuleConfigure(object): - def __init__(self): - pass - def getName(self): return None diff --git a/lib/vdsm/tool/configurators/sanlock.py b/lib/vdsm/tool/configurators/sanlock.py index 566c5e5..9225252 100644 --- a/lib/vdsm/tool/configurators/sanlock.py +++ b/lib/vdsm/tool/configurators/sanlock.py @@ -36,9 +36,6 @@ SANLOCK_GROUPS = (constants.QEMU_PROCESS_GROUP, constants.VDSM_GROUP) - def __init__(self): - super(Sanlock, self).__init__() - def getName(self): return 'sanlock' -- To view, visit http://gerrit.ovirt.org/31740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
