Alon Bar-Lev has posted comments on this change.

Change subject: tool: Remove pointless __init__ methods
......................................................................


Patch Set 2:

the reason for keeping these is that one day one might add some initialization 
at base, and at that day all classes will have to be modified.

this is part of the invalid python design and is addressed by "pointless" code.

this is part of vdsm so do whatever vdsm conventions are, but it does has a 
value in other plains of existence :)

-- 
To view, visit http://gerrit.ovirt.org/31740
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to