Nir Soffer has posted comments on this change. Change subject: Live Merge: Suspend disk stats collection during pivot ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/31367/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5605: elif mode == 'pivot': Line 5606: # A pivot changes the top volume being used for the VM Disk. Until Line 5607: # we can correct our metadata following the pivot we should not Line 5608: # attempt to collect disk stats. Line 5609: self.stopDisksStatsCollection() Are you stopping stats collection for *all* disks? Since this is done base on events, it means that stats collections may never be started again. I rather have a try finally block ensuring that stats collection is started again when the libvirt job is finished, or after a timeout. Line 5610: self.log.info("Requesting pivot to complete active layer commit " Line 5611: "(job %s)", jobID) Line 5612: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT Line 5613: self._dom.blockJobAbort(drive.name, flags) -- To view, visit http://gerrit.ovirt.org/31367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08689aec4d61871a568a6f92661b560fbf4d0b57 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
