Adam Litke has posted comments on this change. Change subject: Live Merge: Suspend disk stats collection during pivot ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/31367/8/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5630: Line 5631: # A pivot changes the top volume being used for the VM Disk. Until Line 5632: # we can correct our metadata following the pivot we should not Line 5633: # attempt to collect disk stats. Line 5634: self.stopDisksStatsCollection() > There's an unanswered question from patch set 6. In this series we are now doing the pivot synchronously. Therefore if stopDisksStatsCollection() is called, we guarantee that we will also call startDisksStatsCollection. So I've addressed nsoffer's concerns I believe. Line 5635: Line 5636: self.log.info("Requesting pivot to complete active layer commit " Line 5637: "(job %s)", jobID) Line 5638: flags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT -- To view, visit http://gerrit.ovirt.org/31367 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08689aec4d61871a568a6f92661b560fbf4d0b57 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
