Francesco Romani has posted comments on this change.

Change subject: vm: simplify the shutdown exit reason
......................................................................


Patch Set 2: Verified+1

Verified using the flows as per QA testing in:
https://bugzilla.redhat.com/show_bug.cgi?id=557125

results:
*** poweroff:
Thread-78::DEBUG::2014-08-22 12:25:42,311::BindingXMLRPC::1144::vds::(wrapper) 
client [192.168.1.64]::call vmDestroy with 
('b63bfabf-6be6-4273-b133-3f8a068f52ac',) {} flowID [209c20e0]
libvirtEventLoop::DEBUG::2014-08-22 
12:25:43,267::vm::2426::vm.Vm::(setDownStatus) 
vmId=`b63bfabf-6be6-4273-b133-3f8a068f52ac`::Changed state to Down: Admin shut 
down from the engine (code=6)
Thread-78::DEBUG::2014-08-22 12:25:43,270::BindingXMLRPC::1151::vds::(wrapper) 
return vmDestroy with {'status': {'message': 'Machine destroyed', 'code': 0}}

*** shutdown from webadmin
Thread-16::DEBUG::2014-08-22 13:01:14,834::BindingXMLRPC::1144::vds::(wrapper) 
client [192.168.1.64]::call vmShutdown with 
('f4d43e7c-a079-42a4-affa-60d6bf1c7fed', '30', 'System Administrator has 
initiated shutdown of this Virtual Machine. Virtual Machine is shutting down.') 
{} flowID [45b95262]
Thread-44::DEBUG::2014-08-22 
13:01:14,836::utils::1053::utils.CallbackChain::(run) Starting callback chain.
Thread-16::DEBUG::2014-08-22 13:01:14,836::BindingXMLRPC::1151::vds::(wrapper) 
return vmShutdown with {'status': {'message': 'Machine shutting down', 'code': 
0}}
Thread-44::DEBUG::2014-08-22 
13:01:14,838::utils::1022::utils.Callback::(__call__) Calling acpiCallback with 
args=() and kwargs={}

Thread-44::DEBUG::2014-08-22 
13:03:14,845::utils::1022::utils.Callback::(__call__) Calling forceCallback 
with args=() and kwargs={}
libvirtEventLoop::INFO::2014-08-22 
13:03:15,316::vm::1982::vm.Vm::(_onQemuDeath) 
vmId=`f4d43e7c-a079-42a4-affa-60d6bf1c7fed`::underlying process disconnected

libvirtEventLoop::DEBUG::2014-08-22 
13:03:15,764::vm::2426::vm.Vm::(setDownStatus) 
vmId=`f4d43e7c-a079-42a4-affa-60d6bf1c7fed`::Changed state to Down: Admin shut 
down from the engine (code=6)
Thread-44::DEBUG::2014-08-22 
13:03:15,766::utils::1060::utils.CallbackChain::(run) Ran out of callbacks

Thread-16::DEBUG::2014-08-22 13:03:17,038::BindingXMLRPC::1144::vds::(wrapper) 
client [192.168.1.64]::call vmGetStats with 
('f4d43e7c-a079-42a4-affa-60d6bf1c7fed',) {} flowID [4d0955bd]
Thread-16::DEBUG::2014-08-22 13:03:17,039::BindingXMLRPC::1151::vds::(wrapper) 
return vmGetStats with {'status': {'message': 'Done', 'code': 0}, 'statsList': 
[{'status': 'Down', 'exitMessage': 'Admin shut down from the engine', 'vmId': 
'f4d43e7c-a079-42a4-affa-60d6bf1c7fed', 'exitReason': 6, 'timeOffset': '0', 
'exitCode': 0}]}

*** shutdown inside vm
libvirtEventLoop::DEBUG::2014-08-22 
13:10:51,584::vm::5180::vm.Vm::(_onLibvirtLifecycleEvent) 
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::event Shutdown detail 0 opaque None
libvirtEventLoop::DEBUG::2014-08-22 
13:10:52,015::vm::5180::vm.Vm::(_onLibvirtLifecycleEvent) 
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::event Stopped detail 0 opaque None
libvirtEventLoop::INFO::2014-08-22 
13:10:52,016::vm::1982::vm.Vm::(_onQemuDeath) 
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::underlying process disconnected
libvirtEventLoop::INFO::2014-08-22 13:10:52,017::vm::4553::vm.Vm::(releaseVm) 
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Release VM resources
libvirtEventLoop::DEBUG::2014-08-22 
13:10:52,354::vm::2426::vm.Vm::(setDownStatus) 
vmId=`56d1c657-dd76-4609-a207-c050699be5be`::Changed state to Down: User shut 
down from within the guest (code=7)
Thread-16::DEBUG::2014-08-22 13:10:52,793::BindingXMLRPC::1144::vds::(wrapper) 
client [192.168.1.64]::call vmGetStats with 
('56d1c657-dd76-4609-a207-c050699be5be',) {} flowID [447fac72]
Thread-16::DEBUG::2014-08-22 13:10:52,793::BindingXMLRPC::1151::vds::(wrapper) 
return vmGetStats with {'status': {'message': 'Done', 'code': 0}, 'statsList': 
[{'status': 'Down', 'exitMessage': 'User shut down from within the guest', 
'vmId': '56d1c657-dd76-4609-a207-c050699be5be', 'exitReason': 7, 'timeOffset': 
'0', 'exitCode': 0}]}

*** reboot inside vm
not affected

-- 
To view, visit http://gerrit.ovirt.org/31354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id03e38fe897d3b36fa7fedc016c2420f67d28385
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to