Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: simplify the shutdown exit reason ......................................................................
vm: simplify the shutdown exit reason A VM could be cleanly shutdown in two ways, either from inside (user shutdown) or from engine (admin shutdown). In turn, the shutdown process can involve various shutdown methods (guest agent, acpi, forced). Currently we use a couple of booleans to detect all the various cases, but this is clumsy and some paths aren't well covered, so wrong states may be reported. This patch simplify the reporting by adding an explicit, private, 'shutdownReason' field. Bug-Url: https://bugzilla.redhat.com/557125 Change-Id: Id03e38fe897d3b36fa7fedc016c2420f67d28385 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31354 Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/31354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id03e38fe897d3b36fa7fedc016c2420f67d28385 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
