Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Remove pointless __init__ methods ......................................................................
tool: Remove pointless __init__ methods Some configurators had pointless __init__ methods. There is not need to implement these if they are empty. Keeping them only cause developers to copy and paste this useless code when they create new configurators. Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31740 Reviewed-by: mooli tayer <[email protected]> Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurators/__init__.py M lib/vdsm/tool/configurators/sanlock.py 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0885600fd8a2257d7d7a3ebe563bf6ee4ca9bb96 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
