Antoni Segura Puimedon has posted comments on this change. Change subject: tc: Integrate Host QoS with network addition via setupNetworks ......................................................................
Patch Set 11: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30467/11/tests/tcTests.py File tests/tcTests.py: Line 83: while True: Line 84: packet = os.read(fd, 2048) Line 85: # check if it is an IP packet Line 86: if ((vlan is None and packet[12:14] == chr(0x08) + chr(0x00)) or Line 87: (packet[12:14] == chr(0x81) + chr(0x00))): Not necessary since no unit test was possible. Line 88: if packet == icmp: Line 89: return Line 90: Line 91: -- To view, visit http://gerrit.ovirt.org/30467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a5378870a3dac9307a6eef8d9937a9c03a0c819 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
