Dan Kenigsberg has posted comments on this change. Change subject: tc: Integrate Host QoS with network addition via setupNetworks ......................................................................
Patch Set 14: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30467/14/vdsm/network/models.py File vdsm/network/models.py: Line 142: ipconfig, mtu) Line 143: Line 144: def __iter__(self): Line 145: yield self Line 146: for dev in self.device: I find using __iter__ for this very awkward. Reading for dev in self.device may lead someone like me to think that self.device is a container of other devices. Instead, it (may) have a device lying under it. I may grow used to this (since I don't have a better idea; is an explicit iter_devices() function any better?), but would you split this change to its own patch with its own tests? It seems like an infrastructure worth a unit test. Line 147: yield dev Line 148: Line 149: def __repr__(self): Line 150: return 'Vlan(%s: %r)' % (self.name, self.device) -- To view, visit http://gerrit.ovirt.org/30467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a5378870a3dac9307a6eef8d9937a9c03a0c819 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
