Dan Kenigsberg has posted comments on this change. Change subject: network/api.py: delete network's orphans + test ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/31336/9/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 2125: @cleanupNet Line 2126: @RequireDummyMod Line 2127: @ValidateRunningAsRoot Line 2128: def testSetupNetworksEmergencyDevicesCleanup(self, bridged): Line 2129: with dummyIf(1) as nics: I'd like to see a test where the relavany devices (all? some?) are pre-used by the network BEFORE the failing setupNetwork. Please add here a successful call to setupNetworks, and make sure that the failed call reverts to whatever was the case before failure. Line 2130: network = {NETWORK_NAME: {'vlan': VLAN_ID, 'bridged': bridged, Line 2131: 'bonding': BONDING_NAME, Line 2132: 'bootproto': 'dhcp', Line 2133: 'blockingdhcp': True}} -- To view, visit http://gerrit.ovirt.org/31336 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3ef7ab74a53a8c2bd49710c01771b623c41cbf88 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
