Antoni Segura Puimedon has posted comments on this change.

Change subject: network/api.py: delete network's orphans + test
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

Please, address my comment and Dan's

http://gerrit.ovirt.org/#/c/31336/9//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2014-08-25 09:12:07 +0200
Line 6: 
Line 7: network/api.py: delete network's orphans + test
Line 8: 
Line 9: When addNetwork fails on ifup, it lefts orphan devices.
s/lefts/leaves/
Line 10: 
Line 11: setupNetworks function is changed to remove leftovers in case of
Line 12: addNetwork's ConfigNetworkError with code ERR_FAILED_IFUP.
Line 13: 


-- 
To view, visit http://gerrit.ovirt.org/31336
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ef7ab74a53a8c2bd49710c01771b623c41cbf88
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to