Adam Litke has posted comments on this change. Change subject: Live Merge: Extend internal block volumes during merge ......................................................................
Patch Set 9: -Verified (2 comments) http://gerrit.ovirt.org/#/c/31268/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2103: self.conf['timeOffset'] = newTimeOffset Line 2104: Line 2105: def _getMergeWriteWatermarks(self): Line 2106: drives = [d for d in self.getDiskDevices() Line 2107: if isVdsmImage(d) and d.blockDev] > s/d/drive/ - or any other more explicit name Done Line 2108: allChains = self._driveGetActualVolumeChain(drives).values() Line 2109: return dict((entry.uuid, entry.allocation) Line 2110: for chain in allChains Line 2111: for entry in chain) Line 2119: Line 2120: try: Line 2121: watermarks = self._getMergeWriteWatermarks() Line 2122: except LookupError: Line 2123: self.log.warning("Failed to look up watermark information") > Is it possible that one single failure prevents the operation for all the d The only times LookupError is raised is for really strange cases (ie. cannot resolve a volume path to volume ID or cannot match a vdsm drive to its corresponding vm xml). In these situations it's best to log an error but not touch anything. Neither of the above cases should ever happen, but if they do, I don't want to kill the stats thread due to an unhandled exception. Line 2124: return ret Line 2125: Line 2126: for job in self.conf['_blockJobs'].values(): Line 2127: try: -- To view, visit http://gerrit.ovirt.org/31268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a9e0ebdb9c42df713c40e0fc5782945eb7228a8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
