Francesco Romani has posted comments on this change. Change subject: Live Merge: Extend internal block volumes during merge ......................................................................
Patch Set 10: Code-Review+1 (1 comment) nice improvement since last revision http://gerrit.ovirt.org/#/c/31268/10/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 5512: Line 5513: return {'status': doneCode} Line 5514: Line 5515: def _diskXMLGetVolumeChainInfo(self, diskXML, drive): Line 5516: def find_element_by_name(doc, name): consistency with the remainder of the module suggests findElementByName, but I don't really care. Let's fix with a (much) later patch; or, even better, let's offload this code to another module later. Line 5517: for child in doc.childNodes: Line 5518: if child.nodeName == name: Line 5519: return child Line 5520: return None -- To view, visit http://gerrit.ovirt.org/31268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a9e0ebdb9c42df713c40e0fc5782945eb7228a8 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
