Dan Kenigsberg has posted comments on this change. Change subject: tool: Create configurators once ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/31739/3/lib/vdsm/tool/configurator.py File lib/vdsm/tool/configurator.py: Line 36: _CONFIGURATORS = dict((m.getName(), m) for m in ( Line 37: certificates.Certificates(), Line 38: libvirt.Libvirt(), Line 39: sanlock.Sanlock(), Line 40: )) > My mistake was looking at the wrong diff: I sneaked this dubious pep8 fix in order to hasten the merge of http://gerrit.ovirt.org/31738. Line 41: Line 42: Line 43: @expose("configure") Line 44: def configure(*args): -- To view, visit http://gerrit.ovirt.org/31739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: jian wang <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
