Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Create configurators once ......................................................................
tool: Create configurators once Commit e5e80540e8 replaced the configurators dict with a function, creating a configuration dict on each call. The code added in this commit invoke the function many times for each run on the tool, creating 10's of instances of the configurators. This change is not needed to acomplish the purpuse of that patch, and is rather pointless. This patch reverts the unrelated change, keeping the configurations in a module constant. This change also simplify the tests. Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31739 Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurator.py M tests/toolTests.py 2 files changed, 23 insertions(+), 24 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e0e258dc28557661bf85734f000e43f20b1e512 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: jian wang <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
