Yaniv Bronhaim has posted comments on this change. Change subject: tool: Remove duplicate names ......................................................................
Patch Set 4: Code-Review+1 not better to call it with something more specific to the module, such as libvirtConfigurator, sanlockConfigurator? i dont really mind, but think it'll be more readable. although this change is necessary and the separation to module requires that naming change. acked it, but still think its better to have specific name for each module -- To view, visit http://gerrit.ovirt.org/31775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
