Francesco Romani has posted comments on this change. Change subject: tool: Remove duplicate names ......................................................................
Patch Set 7: Code-Review+1 (1 comment) ncie :) http://gerrit.ovirt.org/#/c/31775/7//COMMIT_MSG Commit Message: Line 8: Line 9: The configurators modules were duplicating the module name in the class Line 10: name: Line 11: Line 12: libvirt.Libvrit typo, but not worthy a resubmit IMO. Line 13: Line 14: This is not only ugly, but does not describe what this class is. Now all Line 15: the configurtors modules define a Configurator class instead: Line 16: -- To view, visit http://gerrit.ovirt.org/31775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I852019d5b5522a39c03dbf66a3f5383ccf584007 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
