Antoni Segura Puimedon has posted comments on this change. Change subject: tool: Make configurators more Pythonic ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/31741/5/lib/vdsm/tool/configurators/__init__.py File lib/vdsm/tool/configurators/__init__.py: Line 50: The module name to be used with the --module option. Line 51: Line 52: Must be overriden by subclass. Line 53: """ Line 54: return None The proper python behavior if 'Must be overriden by subclass' is true would be to do raise NotImplementedError here. Line 55: Line 56: @property Line 57: def requires(self): Line 58: """ -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16092da09d6763a8222bc941bd7d1501a7bb3bff Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
