Dan Kenigsberg has submitted this change and it was merged. Change subject: tool: Make configurators more Pythonic ......................................................................
tool: Make configurators more Pythonic The configurations used to have Java like getters, which make the code more clumsy then it should be. This patch convert the getters to read only properties. The types returned by the getters were mutable, which may lead to calling code to modify the returned value without any error. Now the configurators return immutable types. There was no documentation about the purpose and the semantics of the getters, which makes it harder for new developer to modify this part. Now ModuleConfigure document these properties. There should be no change in the behavior. Change-Id: I16092da09d6763a8222bc941bd7d1501a7bb3bff Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: http://gerrit.ovirt.org/31741 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: mooli tayer <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M lib/vdsm/tool/configurator.py M lib/vdsm/tool/configurators/__init__.py M lib/vdsm/tool/configurators/certificates.py M lib/vdsm/tool/configurators/libvirt.py M lib/vdsm/tool/configurators/sanlock.py M tests/toolTests.py 6 files changed, 69 insertions(+), 42 deletions(-) Approvals: Nir Soffer: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/31741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16092da09d6763a8222bc941bd7d1501a7bb3bff Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
