Dan Kenigsberg has submitted this change and it was merged. Change subject: networkTests: UNKNOWN operstate ......................................................................
networkTests: UNKNOWN operstate Sometimes kernel is not fast enough to write new device's /sys/class/net/$devicename/operstate in time, in this case originalState read by networkTests:nonChangingOperstate is 'UNKNOWN' and test which it uses fails. This problem occurs with iproute2 on this tests: - testAddNetworkBondWithManyVlans(kwargs=True) - testSetupNetworksAddNetworkToNicAfterBondResizing(kwargs=True) - testSetupNetworksDelOneOfBondNets I added new function _waitForKnownOperstate(device) which waits for operstate other than UNKNOWN. This function is called before every 'with nonChangingOperstate(BOND_NAME)'. I don't use it before 'with nonChangingOperstate(nics[0])', because nics' operstate seems to be UNKNOWN for all the time (bug #1133159). New function uses signal.alert() timeout because monitor's loop blocks code until it gets the right value. Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257 Signed-off-by: Petr Horáček <[email protected]> Reviewed-on: http://gerrit.ovirt.org/30787 Reviewed-by: Antoni Segura Puimedon <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/functional/networkTests.py 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Antoni Segura Puimedon: Looks good to me, but someone else must approve Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/30787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
