Dan Kenigsberg has posted comments on this change. Change subject: networkTests: UNKNOWN operstate ......................................................................
Patch Set 7: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/30787/7/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 165: def _alarmHandler(signum, frame): Line 166: raise Alarm Line 167: Line 168: monitor = ipwrapper.Monitor() Line 169: monitor.start() Please add "try" here, and call monitor.stop() on "finally". Otherwise, we leak a process. Line 170: state = operstate(device).upper() Line 171: if state == 'UNKNOWN': Line 172: signal.signal(signal.SIGALRM, _alarmHandler) Line 173: signal.alarm(timeout) -- To view, visit http://gerrit.ovirt.org/30787 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a5a059e717a331ae5e01cb64b7badc6757d4257 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
