Yeela Kaplan has posted comments on this change. Change subject: oop: change log level ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/31908/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-08-25 15:42:57 +0300 Line 4: Commit: Yeela Kaplan <[email protected]> Line 5: CommitDate: 2014-08-25 15:44:02 +0300 Line 6: Line 7: oop: change log level > The patch looks fine, but the title is misleading. Done Line 8: Line 9: to avoid oop logs in /var/log/messages Line 10: Line 11: Change-Id: Id2d0474d1d69e227aa12b8b70022930f66e7387d http://gerrit.ovirt.org/#/c/31908/1/vdsm/storage/outOfProcess.py File vdsm/storage/outOfProcess.py: Line 216: def rename(self, oldpath, newpath): Line 217: ''' Line 218: WARNING: Renaming a directory is not an atomic op. Line 219: Supported in the same manner as Python's os.rename. Line 220: ''' > in which case I would remove it. let me explain the idea behind this warning. Renaming a directory is not done in an atomic manner, which means this can cause a race. 'Tomorrow', when this race actually happens, the person trying to debug it will have this as a clue. In any case, this bug fix is for the log level of oop and not for this specific comment. Line 221: log.warning("renaming a directory is not an atomic operation") Line 222: try: Line 223: return self._iop.rename(oldpath, newpath) Line 224: except OSError as e: -- To view, visit http://gerrit.ovirt.org/31908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2d0474d1d69e227aa12b8b70022930f66e7387d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
