Saggi Mizrahi has posted comments on this change. Change subject: oop: Use Storage.oop logger ......................................................................
Patch Set 2: Code-Review+2 Sorry, gerrit removed my comment when I did the +2 reposting with comment: Nir, you comments are not relevant here. The wording of the bug is to have the warning not appear in the syslog and this patch solves that. The proper thing to do is to create a separate patch removing this line so that the discussion can be focused on that issue and not on the log configuration issue that the bug is talking about. In any case, that warning is like a deprecation warning. It happens at runtime instead of compile time because there is no way for me to check that in compile time. It is correct that the warning should be displayed only when the fallback is invoked. I'm going to send a patch that moves it, rewords the message and changes it to a debug call as it's only useful for developers. I've asked the storage team for a long time (years) to have their algorithms changes so they don't rename a folder. If it were up to me I'd just have it throw the ENOTEMPTY and break VDSM until it is fixed in the correct place but danken doesn't like it when I break VDSM on purpose. danken: I'm giving +2 and the discussion would continue on my (soon to posted) patch. Having it in syslog is a user facing issue that should be fixed. The rest of nsoffer's incessant bike-shedding could happen *after* user facing issues are solved. -- To view, visit http://gerrit.ovirt.org/31908 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2d0474d1d69e227aa12b8b70022930f66e7387d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Yoav Kleinberger <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
