Francesco Romani has posted comments on this change. Change subject: Add IO tunables support to updateVmPolicy ......................................................................
Patch Set 6: Code-Review+1 (2 comments) seems OK with the updated version in the schema http://gerrit.ovirt.org/#/c/30074/6/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2339: # @guaranteed: IO tune parameters - guaranteed values Line 2340: # Line 2341: # @maximum: IO tune parameters - the hard limits Line 2342: # Line 2343: # Since: 4.15.0 bump version Line 2344: ## Line 2345: {'type': 'VmDiskDeviceTuneLimits', Line 2346: 'data': {'*name': 'str', '*path': 'str', Line 2347: 'guaranteed': 'VmDiskDeviceIoTuneParams', Line 7544: # the VM can consume Line 7545: # Line 7546: # @ioTune: #optional list of ioTune limits to set Line 7547: # Line 7548: # Since: 4.15.0 ditto Line 7549: ## Line 7550: {'type': 'UpdateVmPolicyParams', Line 7551: 'data': {'*vcpuLimit': 'int', Line 7552: '*ioTune': ['VmDiskDeviceTuneLimits']}} -- To view, visit http://gerrit.ovirt.org/30074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ed108fbb2bf9d9af80577b2905242bf9f8c4221 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
