Alon Bar-Lev has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/31561/9/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 201: task_upgraded_version_check(){ Line 202: local upgraded_ver_file="@VDSMLIBDIR@/upgraded_version" Line 203: if [ -f "${upgraded_ver_file}" ]; then Line 204: local ret=0 Line 205: local ver=`cat "${upgraded_ver_file}"` "$(cat ...)" Line 206: if echo "${ver}" | grep -q '^vdsm-4\.10\.'; then Line 207: # We need to treat the upgrade from 4.10.x specifically Line 208: # by running manual configure command Line 209: "$VDSM_TOOL" configure --force Line 208: # by running manual configure command Line 209: "$VDSM_TOOL" configure --force Line 210: ret=$? Line 211: fi Line 212: [ "${ret}" -eq 0 ] && rm "${upgraded_ver_file}" rm -f Line 213: fi Line 214: } Line 215: #### pre-start tasks end #### Line 216: http://gerrit.ovirt.org/#/c/31561/9/vdsm.spec.in File vdsm.spec.in: Line 718: Line 719: # We keep the previous rpm version number in a file for managing upgrade flow Line 720: # in vdsmd_init_script upgraded_version_check task Line 721: if [ "$1" -ge 1 ]; then Line 722: rpm -q %{vdsm_name} > "%{_localstatedir}/lib/%{vdsm_name}/upgraded_version" I do not like rpm information leaks out of spec file. I also do not like the above as upgrade sequence of a->b->c will override the logic. Line 723: fi Line 724: Line 725: %post Line 726: %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
