Alon Bar-Lev has posted comments on this change.

Change subject: Signs vdsm upgraded version for special treatment if required
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/31561/9/vdsm.spec.in
File vdsm.spec.in:

Line 718: 
Line 719: # We keep the previous rpm version number in a file for managing 
upgrade flow
Line 720: # in vdsmd_init_script upgraded_version_check task
Line 721: if [ "$1" -ge 1 ]; then
Line 722:     rpm -q %{vdsm_name} > 
"%{_localstatedir}/lib/%{vdsm_name}/upgraded_version"
> this is the way I found to know previous version.. any better ideas?
every upgrade a->b b->c you override this file, so you end up with version of c.

I do not know why you changed it to store versions, it was good before.
Line 723: fi
Line 724: 
Line 725: %post
Line 726: %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null


-- 
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to