Martin Polednik has uploaded a new change for review. Change subject: vdsm: remove protected attribute access in VmStatsThread ......................................................................
vdsm: remove protected attribute access in VmStatsThread Accessing internal elements is evil, VmStatsThread accessed vm devices through _vm._devices[DISK_DEVICES], which can be replaced by _vm.getDiskDevices() Change-Id: I79736cf6dfa18a251ad050a7fd51b94339a0958b Signed-off-by: Martin Polednik <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/32246/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 1b2d46c..8f1d0b5 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -376,7 +376,7 @@ """ ioTuneInfo = [] - for disk in self._vm._devices[DISK_DEVICES]: + for disk in self._vm.getDiskDevices(): if "ioTune" in disk.specParams: ioTuneInfo.append({ "name": disk.name, -- To view, visit http://gerrit.ovirt.org/32246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I79736cf6dfa18a251ad050a7fd51b94339a0958b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
