Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: remove protected attribute access in VmStatsThread ......................................................................
vdsm: remove protected attribute access in VmStatsThread Accessing internal elements is evil, VmStatsThread accessed vm devices through _vm._devices[DISK_DEVICES], which can be replaced by _vm.getDiskDevices() Change-Id: I79736cf6dfa18a251ad050a7fd51b94339a0958b Signed-off-by: Martin Polednik <[email protected]> Reviewed-on: http://gerrit.ovirt.org/32246 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit http://gerrit.ovirt.org/32246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79736cf6dfa18a251ad050a7fd51b94339a0958b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
