Nir Soffer has posted comments on this change. Change subject: tests: split vm tests helpers in a module ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/32650/2/tests/vmtestlib.py File tests/vmtestlib.py: Line 137: fake.conf['devices'] = [] if devices is None else devices Line 138: fake._guestCpuRunning = runCpu Line 139: if status is not None: Line 140: fake._lastStatus = status Line 141: yield fake > We don't stricly need a context manager here, but we need to be able to red Ok, it makes sense as is. Are you sure that the code depend on constants.P_VDSM_RUN ending with "/"? we should fix such code to use os.path.join, so it will not care about this. -- To view, visit http://gerrit.ovirt.org/32650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied7bb1d38d3814c406a53e1b7dbcac34eb6ffeb7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
