Liron Aravot has posted comments on this change. Change subject: vm: return diskMapping on status() ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/31700/6/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3494: # disk mapping information indexed by property name. Line 3495: # Line 3496: # @name: device logical name within the guest. Line 3497: # Line 3498: # Since: 4.15.0 > 4.17.0 this bug is targeted for 3.5, therefore i'm changing this to 4.16, if i'll have it as 4.17 here when we'll create 3.6 branch from master the version will be wrong. Line 3499: ## Line 3500: {'type': 'GuestDiskMappingInfo', Line 3501: 'data': {'name': 'str'}} Line 3502: Line 3505: # @GuestDisksMappingMap: Line 3506: # Line 3507: # guest disks mapping information indexed by serial. Line 3508: # Line 3509: # Since: 4.15.0 > ditto same Line 3510: ## Line 3511: {'map': 'GuestDisksMappingMap', Line 3512: 'key': 'str', 'value': 'GuestDiskMappingInfo'} Line 3513: Line 3579: # Line 3580: # @guestDiskMapping: A dictionary containing information about the disk Line 3581: # mapping within the guest. The key is the device Line 3582: # serial and the value is the mapping information. Line 3583: # (Added in version 4.15.0.) > Ditto; silly nit: 'New in version' is preferred, but 'Added in version' is Done Line 3584: # Line 3585: # @smartcardEnable: Info whether smartcard is enabled. Line 3586: # Line 3587: # @nicModel: The type of device that is exposed to the VM operating system http://gerrit.ovirt.org/#/c/31700/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2433: def status(self): Line 2434: # used by API.Global.getVMList Line 2435: self.conf['status'] = self.lastStatus Line 2436: # Filter out any internal keys Line 2437: d = dict((k, v) for k, v in self.conf.iteritems() > "status" would nice. Done Line 2438: if not k.startswith("_")) Line 2439: d['guestDiskMapping'] = self.guestAgent.guestDiskMapping Line 2440: return d Line 2441: -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
