Liron Aravot has posted comments on this change. Change subject: vm: return diskMapping on status() ......................................................................
Patch Set 5: (1 comment) Michal, I'm favouring the approach of keeping it as simple as we can. The devices are returned from the saved configuration (see vm.py status() - I think that its better to avoid the further processing here and also to leave this guest returned info 'separated' from possible issues related to the configuration (we already have some today). http://gerrit.ovirt.org/#/c/31700/5/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3578: # @guestIPs: A space separated string of assigned IPv4 addresses Line 3579: # Line 3580: # @guestDiskMapping: A dictionary containing information about the disk mapping Line 3581: # within the guest. The key is the device serial and the value is Line 3582: # the mapping information. > Should add (new in version x.y.z) for this field - see similar notes for ot I added (Added in version 4.15.0.) Line 3583: # Line 3584: # @smartcardEnable: Info whether smartcard is enabled. Line 3585: # Line 3586: # @nicModel: The type of device that is exposed to the VM operating system -- To view, visit http://gerrit.ovirt.org/31700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia68ff3c36ba91cde893876a16fc6702419a60d49 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
