Dan Kenigsberg has posted comments on this change.

Change subject: Add a libvirt migration hook to filter out min_guarantee element
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/32928/2/vdsm/virt/libvirt-hook.sh
File vdsm/virt/libvirt-hook.sh:

Line 2: DOMAIN=$1
Line 3: EVENT=$2
Line 4: PHASE=$3
Line 5: 
Line 6: if [ ! "x$EVENT" == "xmigrate" ]; then
Does this catch also resume after suspend? A VM might have been suspended on 
libvirt 1.2.7 and resumed in a 1.2.8.
Line 7:   exit 0
Line 8: fi
Line 9: 
Line 10: # Fix VMs migrating to host with libvirt >= 1.2.8


-- 
To view, visit http://gerrit.ovirt.org/32928
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to