Martin Sivák has posted comments on this change. Change subject: Add a libvirt migration hook to filter out min_guarantee element ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/32928/3/vdsm/virt/libvirt-hook.sh File vdsm/virt/libvirt-hook.sh: Line 2: DOMAIN=$1 Line 3: EVENT=$2 Line 4: PHASE=$3 Line 5: Line 6: if [ ! "x$EVENT" == "xmigrate" ]; then > Could you check the resume issue with libvirt folks? If no hook is run on r There is no hook for resume and the RFE is here https://bugzilla.redhat.com/show_bug.cgi?id=1142684 Line 7: exit 0 Line 8: fi Line 9: Line 10: # Fix VMs migrating to host with libvirt >= 1.2.8 Line 8: fi Line 9: Line 10: # Fix VMs migrating to host with libvirt >= 1.2.8 Line 11: # See https://bugzilla.redhat.com/show_bug.cgi?id=1138340 Line 12: exec sed -e 's|<min_guarantee[^>]*>[0-9 ]*</min_guarantee>||g' > why's the added [^>]*? (if we are not 100% sure of the text here, we may ne Because I do not care about the attributes. Like <min_guarantee units="KiB"> or so. I was warned against parsing the XML as the libvirt check is sensitive and dumb and any accidental reordering or unrelated change could cause it to reject the xml. There is no min_guarantee tag anywhere else in the XML and this removes it fully. -- To view, visit http://gerrit.ovirt.org/32928 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5e79037b755b257f9cac419887606f66705504 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
