Antoni Segura Puimedon has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing ......................................................................
Patch Set 2: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/33612/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1950: Line 1951: # DHCP source routing configuration is async hence we wait Line 1952: # patiently Line 1953: rules_exist = lambda: (ruleExists(rule1) and ruleExists(rule2)) Line 1954: wait_for_predicate(rules_exist, 10) Good for now. We should eventually replace this with the netlink monitor. Line 1955: routes = [Route.fromText(r) Line 1956: for r in routeShowTable(routing_table)] Line 1957: default_route = Route('0.0.0.0/0', via=IP_GATEWAY, Line 1958: device=str(route_rule_dev)) Line 1955: routes = [Route.fromText(r) Line 1956: for r in routeShowTable(routing_table)] Line 1957: default_route = Route('0.0.0.0/0', via=IP_GATEWAY, Line 1958: device=str(route_rule_dev)) Line 1959: specific_route = Route(IP_NETWORK_AND_CIDR, If I'm not mistaken the proper name for such route would be "link scope route". However, unfortunately, the configuring code does not currently set it with the correct scope (link instead of local). Line 1960: via=str(device_ip_addr), Line 1961: device=str(route_rule_dev)) Line 1962: self.assertIn(default_route, routes) Line 1963: self.assertIn(specific_route, routes) -- To view, visit http://gerrit.ovirt.org/33612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
