Dan Kenigsberg has posted comments on this change. Change subject: Functional test for Multiple Gateways source routing ......................................................................
Patch Set 2: Code-Review-1 (1 comment) Partial review. http://gerrit.ovirt.org/#/c/33612/2/tests/functional/utils.py File tests/functional/utils.py: Line 228: result = self.vdscli.updateVmPolicy([vmId, vcpuLimit]) Line 229: return result['status']['code'], result['status']['message'] Line 230: Line 231: Line 232: def wait_for_predicate(predicate, timeout, poll_period=1): Use vdsm.until.retry instead of this nicely-named function. Line 233: absolute_timeout = time.time() + timeout Line 234: while time.time() <= absolute_timeout: Line 235: res = predicate() Line 236: if res: -- To view, visit http://gerrit.ovirt.org/33612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib510bb56c205dffc98aa2bae3f55c1b4c7f6f56f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
