Francesco Romani has posted comments on this change. Change subject: sampling: allow window=1 in AdvancedStatsFunction ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/28992/8/tests/samplingTests.py File tests/samplingTests.py: Line 167: self.assertEqual(end, values[-1]) Line 168: Line 169: def testElapsedTime(self): Line 170: stat = sampling.AdvancedStatsFunction( Line 171: lambda x: x, interval=1, window=2, timefn=self._faketime) > could be replaced by itertools.count() Done Line 172: for val in range(42): Line 173: stat(val) Line 174: bgn, end, diff = stat.getStats() Line 175: self.assertTrue(diff > 0) # assertGreater requires py >= 2.7 -- To view, visit http://gerrit.ovirt.org/28992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
