Dan Kenigsberg has submitted this change and it was merged. Change subject: sampling: allow window=1 in AdvancedStatsFunction ......................................................................
sampling: allow window=1 in AdvancedStatsFunction A few sampling functions do not need a real sampling window, yet they are forced to use window=2 because it is the minimum allowed size. This patch adds support for the window=1 special case, and a new method to fetch the sample on this case, because the existing API does not fit really well. This patch also adds the initial wave of unit tests for AdvancedStatsFunction. Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/28992 Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/samplingTests.py M vdsm/virt/sampling.py 2 files changed, 83 insertions(+), 0 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ce1fed5a211ed58b7df4728d5bfc3c17fccfbd8 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
