Francesco Romani has posted comments on this change. Change subject: vdsm: Additional ppc64 hardware information ......................................................................
Patch Set 1: Code-Review+1 (2 comments) minor comments, please address the nit in the commit message. Other than that, looks ok. http://gerrit.ovirt.org/#/c/33857/1//COMMIT_MSG Commit Message: Line 4: Commit: Vitor de Lima <[email protected]> Line 5: CommitDate: 2014-10-06 11:09:14 -0300 Line 6: Line 7: vdsm: Additional ppc64 hardware information Line 8: `vdsm' is a bit too generic. I suggest 'caps'. Line 9: Includes extra information (manufacturer and product name) about ppc64 Line 10: hosts in the getVdsHardwareInfo command. This extra information is Line 11: obtained from the device tree and skipped in case it is missing. Line 12: http://gerrit.ovirt.org/#/c/33857/1/vdsm/ppc64HardwareInfo.py File vdsm/ppc64HardwareInfo.py: Line 20: Line 21: import os Line 22: Line 23: Line 24: def getFromDeviceTree(hwInfo, key, treeProperty): For some reasons this looks a bit clumsy, but I don't have suggestions about possible improvements. Line 25: path = '/proc/device-tree/%s' % treeProperty Line 26: try: Line 27: with open(path) as f: Line 28: value = f.readline().rstrip('\0').replace(',', '') -- To view, visit http://gerrit.ovirt.org/33857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f67a830740b64bc246f680f2c7a18a4293f4cc2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
